Feat/service task #745

bjorntore · 2024-09-04T06:52:23Z

Implementing basic support for service task in bpmn.

Moving PDF and eFormidling into service tasks, but also keep legacy implementations and old way of configuring for backwards compatibility for now.

Description

IServiceTask inherits from IProcessTask and behaves in the same way in most cases, except it also has a method called Execute which must be implemented.
The execute method is called in ProcessNext, right next to where we call user action handlers.

    <bpmn:task id="Task_1" name="Utfylling">
      <bpmn:incoming>SequenceFlow_1n56yn5</bpmn:incoming>
      <bpmn:outgoing>SequenceFlow_1oot28q</bpmn:outgoing>
      <bpmn:extensionElements>
        <altinn:taskExtension>
          <altinn:taskType>data</altinn:taskType>
        </altinn:taskExtension>
      </bpmn:extensionElements>
    </bpmn:task>
    <bpmn:serviceTask id="Task_2" name="PDF">
        <bpmn:incoming>SequenceFlow_1oot28q</bpmn:incoming>
        <bpmn:outgoing>SequenceFlow_4ooasd</bpmn:outgoing>
      <bpmn:extensionElements>
        <altinn:taskExtension>
          <altinn:taskType>pdf</altinn:taskType>
          <altinn:pdfConfig>
            <altinn:filename>some.text.resource.binding</altinn:filename>
          </altinn:pdfConfig>
        </altinn:taskExtension>
      </bpmn:extensionElements>
    </bpmn:serviceTask>
    <bpmn:serviceTask id="Task_3" name="eFormidling">
      <bpmn:incoming>SequenceFlow_4ooasd</bpmn:incoming>
      <bpmn:outgoing>SequenceFlow_5assd2s</bpmn:outgoing>
      <bpmn:extensionElements>
        <altinn:taskExtension>
          <altinn:taskType>eFormidling</altinn:taskType>
        </altinn:taskExtension>
      </bpmn:extensionElements>
    </bpmn:serviceTask>

Related Issue(s)

Support servicetask in application process #368

Verification

Your code builds clean without any errors or warnings
Manual testing done (required)
Relevant automated test added (if you find this hard, leave it and we'll help out)
All tests run green

Documentation

User documentation is updated with a separate linked PR in altinn-studio-docs.

Summary by CodeRabbit

New Features
- Service-task support (pdf, eFormidling) with legacy adapters; BPMN element type exposed in process metadata; configurable PDF filename and auto-generate task IDs; environment-aware eFormidling config; telemetry tag for service-task type; extended PDF/eFormidling APIs; service-task execution surface added.
Bug Fixes
- Streamlined process progression with centralized Next/error handling and unified validation→HTTP mapping; consistent authorization path for service tasks.
Tests
- Added and expanded unit/integration tests, fixtures and mocks for service-task, PDF and eFormidling flows.

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs

test/Altinn.App.Api.Tests/Process/ServiceTasks/EFormidling/EFormidlingServiceTaskTests.cs

test/Altinn.App.Api.Tests/Process/ServiceTasks/Pdf/PdfServiceTaskTests.cs

sonarqubecloud · 2024-09-04T08:34:11Z

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

martinothamar

API and stuff LGTM. We discussed

Validation error for trying to invoke actions when current task is a service task
Clear/simple migration story (both old and new apps work) - can we just not run the legacy tasks if a PDF service task refers to the current task for example
Service tasks failing should probably not have 500 status code for the user/client?
Talk to frontenders and Studio team on how the task should be configured

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs

test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs

sonarqubecloud · 2024-10-23T06:46:26Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-12-06T11:08:23Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2025-01-20T11:44:32Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2025-03-10T13:03:34Z

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs

test/Altinn.App.Api.Tests/Process/ServiceTasks/EFormidling/EFormidlingServiceTaskTests.cs

test/Altinn.App.Api.Tests/Process/ServiceTasks/Pdf/PdfServiceTaskTests.cs

...Altinn.App.Core.Tests/Internal/Process/EventHandlers/ProcessTask/EndTaskEventHandlerTests.cs

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs

bjorntore · 2025-07-04T11:56:55Z

/publish

github-actions · 2025-07-04T11:57:59Z

PR release:

⚙️ Building...
✅ Done!

sonarqubecloud · 2025-07-04T12:59:59Z

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnPdfConfiguration.cs (1)

19-21: Consider consistent null handling.

The property is marked nullable (List<string>?) with IsNullable = true, but defaults to a non-null empty list []. This creates ambiguity about whether null is a valid state. Consider either:

Removing the default initializer to allow null as the explicit "not configured" state, or

Making the property non-nullable if an empty list is always valid

The current code works, but explicit semantics would improve clarity.
src/Altinn.App.Core/Internal/Pdf/PdfService.cs (1)
259-293: Consider logging when text resource key is not found.

Lines 265-275: When fileNameTextResourceElementId is provided but the corresponding text resource is not found, the code falls back to using the key itself as the filename (line 274). This might produce unexpected filenames like "pdf.filename.key.pdf".

Consider adding a warning log before line 274 to help identify misconfigurations:
if (textResourceElement is not null)
    return GetValidFileName(textResourceElement.Value);

// Log warning about missing text resource
_logger.LogWarning("Text resource key '{Key}' not found, using key as filename.", fileNameTextResourceElementId);
return GetValidFileName(fileNameTextResourceElementId);

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0982b6a and 7a13da8.

📒 Files selected for processing (7)

src/Altinn.App.Core/Internal/Pdf/IPdfService.cs (1 hunks)
src/Altinn.App.Core/Internal/Pdf/PdfService.cs (9 hunks)
src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnPdfConfiguration.cs (1 hunks)
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs (1 hunks)
test/Altinn.App.Core.Tests/Internal/Pdf/PdfServiceTests.cs (1 hunks)
test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs (1 hunks)
test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt (18 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

test/Altinn.App.Core.Tests/Internal/Pdf/PdfServiceTests.cs

🧰 Additional context used

📓 Path-based instructions (4)

**/*.cs

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.cs: Use internal accessibility on types by default
Use sealed for classes unless inheritance is a valid use-case
Dispose IDisposable/IAsyncDisposable instances
Do not use .GetAwaiter().GetResult(), .Result(), .Wait(), or other blocking APIs on Task
Do not use the Async suffix for async methods
Write efficient code; avoid unnecessary allocations (e.g., avoid repeated ToString calls; consider for-loops over LINQ when appropriate)
Do not invoke the same async operation multiple times in the same code path unless necessary
Avoid awaiting async operations inside tight loops; prefer batching with a sensible upper bound on parallelism
Use CSharpier for formatting (required before commits; formatting also runs on build via CSharpier.MSBuild)

Files:

src/Altinn.App.Core/Internal/Pdf/IPdfService.cs
test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs
src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnPdfConfiguration.cs
src/Altinn.App.Core/Internal/Pdf/PdfService.cs
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs

**/*.{cs,csproj}

📄 CodeRabbit inference engine (CLAUDE.md)

Use Nullable Reference Types

Files:

src/Altinn.App.Core/Internal/Pdf/IPdfService.cs
test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs
src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnPdfConfiguration.cs
src/Altinn.App.Core/Internal/Pdf/PdfService.cs
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs

src/{Altinn.App.Api,Altinn.App.Core}/**/*.cs

📄 CodeRabbit inference engine (CLAUDE.md)

src/{Altinn.App.Api,Altinn.App.Core}/**/*.cs: Types meant to be implemented by apps should be marked with the ImplementableByApps attribute
For HTTP APIs, define DTOs with ...Request and ...Response naming

Files:

src/Altinn.App.Core/Internal/Pdf/IPdfService.cs
src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnPdfConfiguration.cs
src/Altinn.App.Core/Internal/Pdf/PdfService.cs
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs

test/**/*.cs

📄 CodeRabbit inference engine (CLAUDE.md)

test/**/*.cs: Test projects mirror source structure
Prefer xUnit asserts over FluentAssertions
Mock external dependencies with Moq

Files:

test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs

🧠 Learnings (4)

📓 Common learnings

Learnt from: bjorntore
PR: Altinn/app-lib-dotnet#745
File: test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt:3656-3671
Timestamp: 2025-09-25T08:15:25.624Z
Learning: In PR Altinn/app-lib-dotnet#745, the team decided to defer adding idempotency documentation, enriched ServiceTaskFailedResult (code/title/message), and additional OTel spans for service tasks. Do not re-suggest these changes within this PR; propose a follow-up issue instead if needed.

📚 Learning: 2025-08-29T10:45:57.158Z

Learnt from: martinothamar
PR: Altinn/app-lib-dotnet#1456
File: test/Altinn.App.Integration.Tests/_fixture/Tests.cs:3-4
Timestamp: 2025-08-29T10:45:57.158Z
Learning: In Altinn.App.Integration.Tests project, xUnit attributes like [Fact] are available without explicit "using Xunit;" directives, likely through global usings or implicit usings configuration. The code compiles and works as-is.

Applied to files:

test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs

📚 Learning: 2025-09-21T08:19:43.290Z

Learnt from: ivarne
PR: Altinn/app-lib-dotnet#1473
File: test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt:1414-1414
Timestamp: 2025-09-21T08:19:43.290Z
Learning: In Altinn/app-lib-dotnet, *.verified.txt files (e.g., test/**/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt) are verification snapshots for guarding public API. Do not generate review suggestions based on these files; ignore them when assessing code changes.

Applied to files:

test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt

📚 Learning: 2025-09-25T08:15:25.624Z

Learnt from: bjorntore
PR: Altinn/app-lib-dotnet#745
File: test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt:3656-3671
Timestamp: 2025-09-25T08:15:25.624Z
Learning: In PR Altinn/app-lib-dotnet#745, the team decided to defer adding idempotency documentation, enriched ServiceTaskFailedResult (code/title/message), and additional OTel spans for service tasks. Do not re-suggest these changes within this PR; propose a follow-up issue instead if needed.

Applied to files:

test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt

🧬 Code graph analysis (5)

src/Altinn.App.Core/Internal/Pdf/IPdfService.cs (1)

src/Altinn.App.Core/Internal/Pdf/PdfService.cs (1)

List (400-415)

test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs (6)

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs (3)

PdfServiceTask (13-67)

PdfServiceTask (22-27)

Task (33-52)

src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnTaskExtension.cs (1)

AltinnTaskExtension (9-76)

src/Altinn.App.Core/Internal/Process/ProcessReader.cs (14)

AltinnTaskExtension (209-221)

List (41-45)

List (48-52)

List (62-66)

List (69-73)

List (83-87)

List (90-94)

List (97-101)

List (104-108)

List (118-122)

List (125-129)

List (165-182)

List (185-194)

List (197-206)

src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnPdfConfiguration.cs (1)

AltinnPdfConfiguration (8-29)

src/Altinn.App.Core/Internal/Pdf/IPdfService.cs (4)

Task (17-17)

Task (28-34)

Task (42-42)

Task (55-55)

src/Altinn.App.Core/Internal/Pdf/PdfService.cs (8)

Task (71-76)

Task (79-96)

Task (99-112)

Task (115-118)

Task (120-155)

Task (157-193)

Task (243-257)

List (400-415)

src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnPdfConfiguration.cs (4)

src/Altinn.App.Core/Internal/Process/Elements/Process.cs (1)

Process (8-62)

src/Altinn.App.Core/Internal/Pdf/PdfService.cs (1)

List (400-415)

src/Altinn.App.Core/Internal/Process/ProcessReader.cs (13)

List (41-45)

List (48-52)

List (62-66)

List (69-73)

List (83-87)

List (90-94)

List (97-101)

List (104-108)

List (118-122)

List (125-129)

List (165-182)

List (185-194)

List (197-206)

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs (1)

ValidAltinnPdfConfiguration (54-66)

src/Altinn.App.Core/Internal/Pdf/PdfService.cs (1)

src/Altinn.App.Core/Internal/Pdf/IPdfService.cs (4)

Task (17-17)

Task (28-34)

Task (42-42)

Task (55-55)

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs (4)

src/Altinn.App.Core/Internal/Pdf/IPdfService.cs (3)

Task (17-17)

Task (28-34)

Task (42-42)

src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnPdfConfiguration.cs (2)

ValidAltinnPdfConfiguration (23-28)

AltinnPdfConfiguration (8-29)

src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnTaskExtension.cs (1)

AltinnTaskExtension (9-76)

src/Altinn.App.Core/Internal/Process/ProcessReader.cs (1)

AltinnTaskExtension (209-221)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: Run dotnet build and test (windows-latest)
GitHub Check: Run dotnet build and test (ubuntu-latest)
GitHub Check: Run dotnet build and test (macos-latest)
GitHub Check: Static code analysis
GitHub Check: Analyze (csharp)

🔇 Additional comments (18)

src/Altinn.App.Core/Internal/Pdf/IPdfService.cs (2)

15-15: Documentation typo fixes look good.

The corrections from "witch" to "which" improve the documentation quality.

Also applies to: 40-40

19-34: No action required: PdfService explicitly overrides the new overload and forwards all parameters, so the default implementation is never used and there’s no silent parameter ignore.

src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnPdfConfiguration.cs (3)

8-14: LGTM!

The class is correctly marked as sealed, follows the coding guidelines, and the Filename property is properly configured with XML serialization attributes to support text resource keys.

23-28: LGTM!

The Validate() method correctly normalizes Filename by trimming and converting whitespace-only values to null, which prevents empty strings from being passed downstream. The AutoPdfTaskIds list is passed through as-is, which is appropriate for a collection property.

31-31: LGTM!

The internal readonly record struct is an appropriate and efficient choice for encapsulating validated configuration data.

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs (3)

8-17: LGTM!

The class is correctly marked as internal sealed per coding guidelines, and the constructor dependencies are appropriate for the PDF generation task.

33-52: Confirm taskId is not user-controlled input.

Static analysis flagged Lines 38 and 49 for logging user-provided values. The taskId comes from instance.Process.CurrentTask.ElementId, which should be a BPMN process model identifier controlled by the app developer rather than end-user input.

Please confirm this is the case to dismiss the security concern.

54-66: LGTM!

The helper method correctly handles both configured and unconfigured scenarios, providing a sensible default when no PDF configuration is specified in the BPMN model. The null-safe navigation and validation flow are appropriate.

test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs (3)

12-34: LGTM!

The test setup follows good practices with inline mock initialization and appropriate default configuration for the ProcessReader mock. The structure supports test reusability.

36-65: LGTM!

The test correctly verifies that Execute calls GenerateAndStorePdf with the expected parameters. The use of It.IsAny<>() for AutoPdfTaskIds and CancellationToken is appropriate given this test focuses on the core invocation.

67-103: LGTM!

The test correctly verifies that AutoPdfTaskIds are propagated through to GenerateAndStorePdf. Creating a separate PdfServiceTask instance for this test is appropriate to avoid interference with the default setup.

src/Altinn.App.Core/Internal/Pdf/PdfService.cs (7)

70-76: LGTM!

The original method now correctly delegates to GenerateAndStorePdfInternal with null for the new parameters, maintaining backward compatibility.

78-96: LGTM!

The new overload correctly extends the public API to support filename and auto-PDF task configuration, with appropriate default parameter values.

120-155: LGTM!

The internal method correctly consolidates the PDF generation and storage logic, properly disposes the stream with await using, and passes through the extended configuration parameters appropriately.

99-111: LGTM!

The changes correctly integrate autoGeneratePdfForTaskIds into the PDF content generation flow, converting task IDs to query parameters and appending them to the URI.

Also applies to: 157-193

195-223: LGTM!

The BuildUri method correctly handles additional query parameters, and the string concatenation approach was acknowledged as acceptable by the maintainer for this use case.

339-347: LGTM!

The helper correctly ensures the .pdf extension is present using a case-insensitive check, which is appropriate for file extensions.

400-415: LGTM!

The helper correctly converts task IDs into query parameters with repeated task keys, which is the standard approach for array-like query parameters in URLs.

coderabbitai

Actionable comments posted: 1

♻️ Duplicate comments (1)

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs (1)
1-7: Missing using directive prevents compilation.

The IProcessReader type (line 17) requires a namespace import. This issue was flagged in a previous review.

Apply this diff:
 using Altinn.App.Core.Helpers;
 using Altinn.App.Core.Internal.Pdf;
+using Altinn.App.Core.Internal.Process;
 using Altinn.App.Core.Internal.Process.Elements.AltinnExtensionProperties;
 using Altinn.Platform.Storage.Interface.Models;
 using Microsoft.Extensions.Logging;

🧹 Nitpick comments (1)

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs (1)
427-432: Clarify error handling for service task implementation bugs.

If a service task fails to handle abandon issues, the thrown exception will be caught by the generic catch block (line 440), which logs "Service task failed with an exception!" This masks the specific implementation error. Consider either:

Rethrowing this exception type so it's not caught by the generic handler, or

Logging a more specific message before throwing

This would help distinguish between service task execution failures and implementation bugs.

Apply this diff to log a specific message before throwing:
         if (cachedDataMutator.HasAbandonIssues)
         {
+            _logger.LogError(
+                "Service task {ServiceTaskType} implementation error: Abandon issues found in data elements but not handled by the service task.",
+                serviceTask.Type
+            );
             throw new Exception(
                 "Abandon issues found in data elements. Abandon issues should be handled by the service task."
             );
         }

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a13da8 and 73b8d83.

📒 Files selected for processing (3)

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs (11 hunks)
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs (1 hunks)
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.cs

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.cs: Use internal accessibility on types by default
Use sealed for classes unless inheritance is a valid use-case
Dispose IDisposable/IAsyncDisposable instances
Do not use .GetAwaiter().GetResult(), .Result(), .Wait(), or other blocking APIs on Task
Do not use the Async suffix for async methods
Write efficient code; avoid unnecessary allocations (e.g., avoid repeated ToString calls; consider for-loops over LINQ when appropriate)
Do not invoke the same async operation multiple times in the same code path unless necessary
Avoid awaiting async operations inside tight loops; prefer batching with a sensible upper bound on parallelism
Use CSharpier for formatting (required before commits; formatting also runs on build via CSharpier.MSBuild)

Files:

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs

**/*.{cs,csproj}

📄 CodeRabbit inference engine (CLAUDE.md)

Use Nullable Reference Types

Files:

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs

src/{Altinn.App.Api,Altinn.App.Core}/**/*.cs

📄 CodeRabbit inference engine (CLAUDE.md)

src/{Altinn.App.Api,Altinn.App.Core}/**/*.cs: Types meant to be implemented by apps should be marked with the ImplementableByApps attribute
For HTTP APIs, define DTOs with ...Request and ...Response naming

Files:

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs

🧠 Learnings (3)

📓 Common learnings

Learnt from: bjorntore
PR: Altinn/app-lib-dotnet#745
File: test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt:3656-3671
Timestamp: 2025-09-25T08:15:25.624Z
Learning: In PR Altinn/app-lib-dotnet#745, the team decided to defer adding idempotency documentation, enriched ServiceTaskFailedResult (code/title/message), and additional OTel spans for service tasks. Do not re-suggest these changes within this PR; propose a follow-up issue instead if needed.

📚 Learning: 2025-09-25T11:15:19.192Z

Learnt from: bjorntore
PR: Altinn/app-lib-dotnet#745
File: src/Altinn.App.Core/Internal/Process/ProcessEngine.cs:276-276
Timestamp: 2025-09-25T11:15:19.192Z
Learning: In ProcessEngine.Next(), HandleMoveToNext intentionally uses request.Action (original, potentially null) rather than checkedAction (resolved with defaults). This distinction is important for navigation logic, even though it may appear inconsistent with how authorization and service task execution use the resolved action.

Applied to files:

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

📚 Learning: 2025-09-25T08:15:25.624Z

Learnt from: bjorntore
PR: Altinn/app-lib-dotnet#745
File: test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt:3656-3671
Timestamp: 2025-09-25T08:15:25.624Z
Learning: In PR Altinn/app-lib-dotnet#745, the team decided to defer adding idempotency documentation, enriched ServiceTaskFailedResult (code/title/message), and additional OTel spans for service tasks. Do not re-suggest these changes within this PR; propose a follow-up issue instead if needed.

Applied to files:

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs
src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs

🧬 Code graph analysis (3)

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs (7)

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs (2)

Task (44-77)

Task (79-95)

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs (1)

Task (34-56)

src/Altinn.App.Api/Controllers/ProcessController.cs (3)

Task (479-519)

Task (623-653)

Task (655-658)

src/Altinn.App.Core/Helpers/LogSanitizer.cs (2)

LogSanitizer (9-45)

Sanitize (22-38)

src/Altinn.App.Core/Internal/Process/ProcessReaderExtensions.cs (1)

IsActionAllowedForTask (13-23)

src/Altinn.App.Core/Internal/Data/InstanceDataUnitOfWork.cs (3)

InstanceDataUnitOfWork (24-701)

InstanceDataUnitOfWork (65-98)

DataElementChanges (351-428)

src/Altinn.App.Core/Models/Validation/ValidationIssueWithSource.cs (2)

ValidationIssueWithSource (10-118)

ValidationIssueWithSource (15-32)

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs (6)

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs (12)

IServiceTask (313-324)

Task (74-141)

Task (144-292)

Task (295-310)

Task (326-378)

Task (380-453)

Task (458-487)

Task (492-514)

Task (516-588)

Task (590-643)

Task (645-658)

Task (663-676)

src/Altinn.App.Core/EFormidling/Implementation/DefaultEFormidlingService.cs (3)

Task (71-74)

Task (77-80)

Task (82-138)

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/IServiceTask.cs (1)

Task (14-14)

src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnEFormidlingConfiguration.cs (2)

ValidAltinnEFormidlingConfiguration (66-96)

AltinnEFormidlingConfiguration (10-199)

src/Altinn.App.Core/Helpers/LogSanitizer.cs (2)

LogSanitizer (9-45)

Sanitize (22-38)

src/Altinn.App.Core/Internal/Process/ProcessReader.cs (1)

AltinnTaskExtension (209-221)

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs (5)

src/Altinn.App.Core/Internal/Pdf/IPdfService.cs (3)

Task (17-17)

Task (28-34)

Task (42-42)

src/Altinn.App.Core/Helpers/LogSanitizer.cs (2)

LogSanitizer (9-45)

Sanitize (22-38)

src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnPdfConfiguration.cs (2)

ValidAltinnPdfConfiguration (23-28)

AltinnPdfConfiguration (8-29)

src/Altinn.App.Core/Internal/Process/Elements/AltinnExtensionProperties/AltinnTaskExtension.cs (1)

AltinnTaskExtension (9-76)

src/Altinn.App.Core/Internal/Process/ProcessReader.cs (1)

AltinnTaskExtension (209-221)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: Static code analysis
GitHub Check: Analyze (csharp)
GitHub Check: Run dotnet build and test (macos-latest)
GitHub Check: Run dotnet build and test (windows-latest)
GitHub Check: Run dotnet build and test (ubuntu-latest)

🔇 Additional comments (5)

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs (2)

703-760: LGTM: Well-structured validation helper.

The TryGetCurrentTaskIdAndAltinnTaskType method follows C# conventions properly, uses nullability attributes correctly, and provides clear error messages for each validation case. The extraction of this logic from the main Next method improves readability and maintainability.

144-292: LGTM: Well-structured refactor of the Next method.

The refactored Next method follows a clear flow: authorization → service task or user action execution → conditional validation → process advancement. Key improvements:

Authorization and validation are properly integrated

Service tasks and user actions are routed correctly

Error handling provides specific error types and messages

Telemetry tracks each phase

Validation is appropriately skipped for reject actions and service tasks

The logic is well-organized and maintains backward compatibility while adding new capabilities.

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/PdfServiceTask.cs (3)

39-39: Static analysis warnings are false positives.

The static analysis tool flagged logging taskId as a security risk (log injection). However, the code correctly applies LogSanitizer.Sanitize() before logging, which removes control characters and limits length, mitigating injection risks.

Also applies to: 50-53

36-36: Remove null check suggestion for CurrentTask.ElementId

Service task contexts always supply a non-null CurrentTask and the codebase consistently accesses ElementId directly, so a null check here is unnecessary.

Likely an incorrect or invalid review comment.

58-70: Exception handling for missing task extensions is consistent. All service tasks propagate the ProcessException from GetAltinnTaskExtension and default null configurations.

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs

bjorntore · 2025-10-14T09:07:37Z

/publish

github-actions · 2025-10-14T09:07:48Z

PR release:

⚙️ Building...
✅ Done!

coderabbitai

Actionable comments posted: 0

♻️ Duplicate comments (1)

src/Altinn.App.Api/Controllers/ProcessController.cs (1)
47-68: Avoid service locator; inject InstanceDataUnitOfWorkInitializer directly

The constructor still uses IServiceProvider to resolve InstanceDataUnitOfWorkInitializer on line 67. This anti-pattern hides dependencies and complicates testing.

As per the previous review, make InstanceDataUnitOfWorkInitializer accessible for direct injection by either:

Making the class public in src/Altinn.App.Core/Internal/Data/InstanceDataUnitOfWorkInitializer.cs, OR

Adding [assembly: InternalsVisibleTo("Altinn.App.Api")] in Core

Then update the constructor:
     public ProcessController(
         ILogger<ProcessController> logger,
         IInstanceClient instanceClient,
         IProcessClient processClient,
         IValidationService validationService,
         IAuthorizationService authorization,
         IProcessReader processReader,
         IProcessEngine processEngine,
-        IServiceProvider serviceProvider,
+        InstanceDataUnitOfWorkInitializer instanceDataUnitOfWorkInitializer,
         IProcessEngineAuthorizer processEngineAuthorizer
     )
     {
         _logger = logger;
         _instanceClient = instanceClient;
         _processClient = processClient;
         _authorization = authorization;
         _processReader = processReader;
         _processEngine = processEngine;
         _processEngineAuthorizer = processEngineAuthorizer;
         _validationService = validationService;
-        _instanceDataUnitOfWorkInitializer = serviceProvider.GetRequiredService<InstanceDataUnitOfWorkInitializer>();
+        _instanceDataUnitOfWorkInitializer = instanceDataUnitOfWorkInitializer;
     }

🧹 Nitpick comments (1)

src/Altinn.App.Api/Controllers/ProcessController.cs (1)

508-556: Consider exhaustive pattern matching for ProcessErrorType

The centralized error handling is well-designed. For additional safety, consider using an exhaustive switch expression or adding a guard clause to ensure all ProcessErrorType enum values are explicitly handled:

 private ActionResult<AppProcessState> GetResultForError(ProcessChangeResult result)
 {
-    switch (result.ErrorType)
+    return result.ErrorType switch
     {
-        case ProcessErrorType.Conflict:
-            return Conflict(
+        ProcessErrorType.Conflict => Conflict(
                 new ProblemDetails()
                 {
                     Detail = result.ErrorMessage,
                     Status = StatusCodes.Status409Conflict,
                     Title = result.ErrorTitle,
                     Extensions = new Dictionary<string, object?>
                     {
                         { "validationIssues", result.ValidationIssues },
                     },
                 }
             ),
-        case ProcessErrorType.Internal:
-            return StatusCode(
+        ProcessErrorType.Internal => StatusCode(
                 500,
                 new ProblemDetails()
                 {
                     Detail = result.ErrorMessage,
                     Status = StatusCodes.Status500InternalServerError,
                     Title = result.ErrorTitle ?? "Internal server error",
                 }
             ),
-        case ProcessErrorType.Unauthorized:
-            return StatusCode(
+        ProcessErrorType.Unauthorized => StatusCode(
                 403,
                 new ProblemDetails()
                 {
                     Detail = result.ErrorMessage,
                     Status = StatusCodes.Status403Forbidden,
                     Title = result.ErrorTitle ?? "Unauthorized",
                 }
             ),
-        default:
-            return StatusCode(
+        _ => StatusCode(
                 500,
                 new ProblemDetails()
                 {
                     Detail = $"Unknown ProcessErrorType {result.ErrorType}",
                     Status = StatusCodes.Status500InternalServerError,
                     Title = result.ErrorTitle ?? "Internal server error",
                 }
-            );
-    }
+            ),
+    };
 }

This makes the compiler warn if new enum values are added without updating the switch.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98bae5e and cb9b661.

📒 Files selected for processing (5)

src/Altinn.App.Api/Controllers/ProcessController.cs (9 hunks)
src/Altinn.App.Core/Extensions/ServiceCollectionExtensions.cs (2 hunks)
test/Altinn.App.Api.Tests/Controllers/ProcessControllerTests.RunProcessNext_FailingValidator_ReturnsValidationErrors.verified.txt (1 hunks)
test/Altinn.App.Api.Tests/Controllers/ProcessControllerTests.RunProcessNext_PdfFails_DataIsUnlocked.verified.txt (0 hunks)
test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt (18 hunks)

💤 Files with no reviewable changes (1)

test/Altinn.App.Api.Tests/Controllers/ProcessControllerTests.RunProcessNext_PdfFails_DataIsUnlocked.verified.txt

🚧 Files skipped from review as they are similar to previous changes (2)

src/Altinn.App.Core/Extensions/ServiceCollectionExtensions.cs
test/Altinn.App.Api.Tests/Controllers/ProcessControllerTests.RunProcessNext_FailingValidator_ReturnsValidationErrors.verified.txt

🧰 Additional context used

📓 Path-based instructions (3)

**/*.cs

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.cs: Use internal accessibility on types by default
Use sealed for classes unless inheritance is a valid use-case
Dispose IDisposable/IAsyncDisposable instances
Do not use .GetAwaiter().GetResult(), .Result(), .Wait(), or other blocking APIs on Task
Do not use the Async suffix for async methods
Write efficient code; avoid unnecessary allocations (e.g., avoid repeated ToString calls; consider for-loops over LINQ when appropriate)
Do not invoke the same async operation multiple times in the same code path unless necessary
Avoid awaiting async operations inside tight loops; prefer batching with a sensible upper bound on parallelism
Use CSharpier for formatting (required before commits; formatting also runs on build via CSharpier.MSBuild)

Files:

src/Altinn.App.Api/Controllers/ProcessController.cs

**/*.{cs,csproj}

📄 CodeRabbit inference engine (CLAUDE.md)

Use Nullable Reference Types

Files:

src/Altinn.App.Api/Controllers/ProcessController.cs

src/{Altinn.App.Api,Altinn.App.Core}/**/*.cs

📄 CodeRabbit inference engine (CLAUDE.md)

src/{Altinn.App.Api,Altinn.App.Core}/**/*.cs: Types meant to be implemented by apps should be marked with the ImplementableByApps attribute
For HTTP APIs, define DTOs with ...Request and ...Response naming

Files:

src/Altinn.App.Api/Controllers/ProcessController.cs

🧠 Learnings (3)

📓 Common learnings

Learnt from: bjorntore
PR: Altinn/app-lib-dotnet#745
File: test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt:3656-3671
Timestamp: 2025-09-25T08:15:25.624Z
Learning: In PR Altinn/app-lib-dotnet#745, the team decided to defer adding idempotency documentation, enriched ServiceTaskFailedResult (code/title/message), and additional OTel spans for service tasks. Do not re-suggest these changes within this PR; propose a follow-up issue instead if needed.

📚 Learning: 2025-09-25T11:15:19.192Z

Learnt from: bjorntore
PR: Altinn/app-lib-dotnet#745
File: src/Altinn.App.Core/Internal/Process/ProcessEngine.cs:276-276
Timestamp: 2025-09-25T11:15:19.192Z
Learning: In ProcessEngine.Next(), HandleMoveToNext intentionally uses request.Action (original, potentially null) rather than checkedAction (resolved with defaults). This distinction is important for navigation logic, even though it may appear inconsistent with how authorization and service task execution use the resolved action.

Applied to files:

src/Altinn.App.Api/Controllers/ProcessController.cs

📚 Learning: 2025-09-25T08:15:25.624Z

Learnt from: bjorntore
PR: Altinn/app-lib-dotnet#745
File: test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt:3656-3671
Timestamp: 2025-09-25T08:15:25.624Z
Learning: In PR Altinn/app-lib-dotnet#745, the team decided to defer adding idempotency documentation, enriched ServiceTaskFailedResult (code/title/message), and additional OTel spans for service tasks. Do not re-suggest these changes within this PR; propose a follow-up issue instead if needed.

Applied to files:

test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt

🧬 Code graph analysis (1)

src/Altinn.App.Api/Controllers/ProcessController.cs (5)

src/Altinn.App.Core/Internal/Data/InstanceDataUnitOfWorkInitializer.cs (2)

InstanceDataUnitOfWorkInitializer (15-71)

InstanceDataUnitOfWorkInitializer (29-48)

src/Altinn.App.Core/Models/Process/ProcessChangeResult.cs (1)

ProcessChangeResult (9-42)

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs (13)

ConvertTaskTypeToAction (755-772)

Task (80-147)

Task (150-213)

Task (218-349)

Task (366-381)

Task (397-449)

Task (451-524)

Task (529-558)

Task (563-585)

Task (587-659)

Task (661-714)

Task (716-729)

Task (734-747)

src/Altinn.App.Core/Internal/Process/Elements/ProcessTask.cs (2)

ElementType (21-24)

ProcessTask (9-25)

src/Altinn.App.Core/Internal/Process/Elements/AppProcessTaskTypeInfo.cs (1)

AppProcessTaskTypeInfo (10-29)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: Static code analysis
GitHub Check: Analyze (csharp)
GitHub Check: Run dotnet build and test (ubuntu-latest)
GitHub Check: Run dotnet build and test (windows-latest)

🔇 Additional comments (5)

src/Altinn.App.Api/Controllers/ProcessController.cs (5)

256-303: Simplified flow correctly delegates iteration to ProcessEngine

The NextElement method now constructs a single ProcessNextRequest and delegates to _processEngine.Next(), which handles iterative service-task execution internally. This resolves the stale-state loop concern from previous reviews where the controller was checking IsServiceTask on the pre-Next instance.

The structured logging improvement on line 296 is also a good practice.

612-642: Validation helper correctly supports CompleteProcess flow

The GetValidationProblemDetails method provides necessary pre-validation for the CompleteProcess loop (lines 366-409). While similar logic exists in ProcessEngine.ProcessNext, this duplication is intentional: CompleteProcess must validate before each iteration to determine whether to continue the loop, whereas ProcessNext validates internally as part of the process change.

The method correctly uses InstanceDataUnitOfWorkInitializer and IValidationService, and formats errors consistently with GetResultForError.

391-398: LGTM: Clean ProcessNextRequest construction

The use of target-typed new() and proper action conversion via ConvertTaskTypeToAction is clean and idiomatic.

486-501: ElementType wiring supports new BPMN surface

The additions of ElementType to CurrentTask (line 486) and ProcessTasks (line 497) correctly populate the new API surface properties. This aligns with the PR's service-task feature and enables element-type-based behavior in the frontend.

The use of flowElement.ElementType() and processElement.ElementType() properly delegates to the process element model's type identification.

649-666: Action mapping correctly extends for service tasks

Adding "pdf" and "eFormidling" to the action conversion is consistent with the engine-side mapping (see ProcessEngine.ConvertTaskTypeToAction) and appropriately maps these service-task types to the "write" action.

coderabbitai

Actionable comments posted: 1

♻️ Duplicate comments (4)

test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt (4)
3582-3587: IProcessEngine additions are breaking for implementers — use default interface bodies.

This was already flagged earlier; ensure default bodies exist to preserve compat (especially CheckIfServiceTask and old Next signature forwarding).
#!/bin/bash
ast-grep --pattern $'interface IProcessEngine { $$$ }' --lang cs -n -C3
3628-3633: ProcessEngine ctor expanded — add an [Obsolete] overload that forwards.

Previously raised; confirm a compat ctor exists to avoid binary/source breaks.
#!/bin/bash
rg -nP --type=cs 'class\s+ProcessEngine\b' -C5
3381-3383: elementType casing consistency (lowerCamelCase).

Already noted earlier; ensure overrides return lowerCamelCase to match JSON/client expectations.

Also applies to: 3405-3406

4705-4705: Plumb new fields to API responses and telemetry.

Ensure ErrorTitle and ValidationIssues are wired through controllers and telemetry tags; previously raised.

Also applies to: 4721-4722

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 318b9a9 and 5d30397.

📒 Files selected for processing (1)

test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt (18 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: bjorntore
PR: Altinn/app-lib-dotnet#745
File: test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt:3656-3671
Timestamp: 2025-09-25T08:15:25.624Z
Learning: In PR Altinn/app-lib-dotnet#745, the team decided to defer adding idempotency documentation, enriched ServiceTaskFailedResult (code/title/message), and additional OTel spans for service tasks. Do not re-suggest these changes within this PR; propose a follow-up issue instead if needed.

📚 Learning: 2025-09-25T08:15:25.624Z

Learnt from: bjorntore
PR: Altinn/app-lib-dotnet#745
File: test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt:3656-3671
Timestamp: 2025-09-25T08:15:25.624Z
Learning: In PR Altinn/app-lib-dotnet#745, the team decided to defer adding idempotency documentation, enriched ServiceTaskFailedResult (code/title/message), and additional OTel spans for service tasks. Do not re-suggest these changes within this PR; propose a follow-up issue instead if needed.

Applied to files:

test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: Run dotnet build and test (windows-latest)
GitHub Check: Run dotnet build and test (macos-latest)
GitHub Check: Run dotnet build and test (ubuntu-latest)
GitHub Check: Static code analysis
GitHub Check: Analyze (csharp)

🔇 Additional comments (2)

test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt (2)

4737-4744: Verify whether ProcessNextRequest sealing is a new change in this PR.

ProcessNextRequest is currently defined as public sealed record. I cannot determine from the codebase alone whether sealing is new in this PR or was pre-existing. If the sealing is a new addition in this PR, the concern about breaking inheritance is valid—sealed records prevent consumers from deriving custom implementations. If it was already sealed, no action is needed.

Check the PR diff to confirm: (1) was ProcessNextRequest previously unsealed, and (2) is this sealing intentional per versioning policy (breaking change acceptable for next major version)?

191-199: ****

The interfaces IEFormidlingReceivers and IEFormidlingService already have default implementations for the new overload methods. The second GetEFormidlingReceivers overload forwards to the first method, and the second SendEFormidlingShipment overload forwards to the first method with an explicit backward-compatibility comment. Both DefaultEFormidlingReceivers and DefaultEFormidlingService successfully implement all overloads without compilation issues. No breaking change exists, and no modifications are needed.

Likely an incorrect or invalid review comment.

.../Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt

# Conflicts: # src/Altinn.App.Core/Internal/Pdf/PdfService.cs

bjorntore · 2025-10-30T08:29:26Z

/publish

github-actions · 2025-10-30T08:30:35Z

PR release:

⚙️ Building...
✅ Done!

…1548)

sonarqubecloud · 2025-10-30T09:53:16Z

Quality Gate passed

Issues
21 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bjorntore · 2025-10-30T10:02:57Z

/publish

github-actions · 2025-10-30T10:03:16Z

PR release:

⚙️ Building...
✅ Done!

github-advanced-security bot found potential problems Sep 4, 2024

View reviewed changes

github-advanced-security bot found potential problems Sep 30, 2024

View reviewed changes

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs Fixed Show fixed Hide fixed

martinothamar approved these changes Oct 2, 2024

View reviewed changes

bjorntore force-pushed the feat/pdf-service-task branch from 7584f9a to 6aacedf Compare October 9, 2024 06:00

ivarne reviewed Oct 9, 2024

View reviewed changes

src/Altinn.App.Core/Internal/Process/ProcessEngine.cs Show resolved Hide resolved

ivarne reviewed Oct 9, 2024

View reviewed changes

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs Outdated Show resolved Hide resolved

ivarne reviewed Oct 9, 2024

View reviewed changes

test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs Outdated Show resolved Hide resolved

ivarne reviewed Oct 9, 2024

View reviewed changes

test/Altinn.App.Core.Tests/Internal/Process/ServiceTasks/PdfServiceTaskTests.cs Outdated Show resolved Hide resolved

bjorntore mentioned this pull request Oct 23, 2024

Service task support in user interface Altinn/app-frontend-react#2349

Closed

7 tasks

bjorntore added the feature Label Pull requests with new features. Used when generation releasenotes label Nov 25, 2024

bjorntore self-assigned this Jun 18, 2025

bjorntore added the backport-ignore This PR is a new feature and should not be cherry-picked onto release branches label Jun 18, 2025

bjorntore force-pushed the feat/pdf-service-task branch from 1d3fd8d to 9ec36c7 Compare June 18, 2025 08:19

github-advanced-security bot found potential problems Jun 18, 2025

View reviewed changes

bjorntore force-pushed the feat/pdf-service-task branch 5 times, most recently from 6ef10b3 to 9b6b142 Compare June 24, 2025 09:53

github-advanced-security bot found potential problems Jul 4, 2025

View reviewed changes

bjorntore force-pushed the feat/pdf-service-task branch from bb80fbe to 70a69eb Compare July 4, 2025 11:56

bjorntore mentioned this pull request Jul 4, 2025

Add authorization case for pdf and eFormilding service tasks. Altinn/altinn-storage#749

Merged

5 tasks

Remove data type config for pdf.

7a13da8

coderabbitai bot reviewed Oct 13, 2025

View reviewed changes

Sanitize more logs to satisfy sonar.

73b8d83

coderabbitai bot reviewed Oct 13, 2025

View reviewed changes

src/Altinn.App.Core/Internal/Process/ProcessTasks/ServiceTasks/EFormidlingServiceTask.cs Show resolved Hide resolved

bjorntore added 10 commits October 15, 2025 10:49

Merge branch 'main' into feat/pdf-service-task

1c7a32c

Remove trailing semicolon.

88032fb

Fix typo.

2315a72

Remove trailing semicolon.

f5e7499

Fix typo.

dd2d8ea

Null guard.

4b41c50

Move process next do while inside process engine.

1782006

Merge branch 'main' into feat/pdf-service-task

98bae5e

Merge branch 'main' into feat/pdf-service-task

9b652c2

Merge branch 'main' into feat/pdf-service-task

cb9b661

coderabbitai bot reviewed Oct 22, 2025

View reviewed changes

bjorntore added 2 commits October 22, 2025 13:54

Merge branch 'main' into feat/pdf-service-task

318b9a9

Merge branch 'main' into feat/pdf-service-task

5d30397

coderabbitai bot reviewed Oct 27, 2025

View reviewed changes

.../Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt Show resolved Hide resolved

bjorntore added 2 commits October 29, 2025 14:42

Merge branch 'main' into feat/pdf-service-task

33ce78c

# Conflicts: # src/Altinn.App.Core/Internal/Pdf/PdfService.cs

Unit test custom pdf file name.

fa043be

ProcessEngine and related tweaks from feature/fiks-io-client branch (#…

431ac68

…1548)

bjorntore merged commit 8a37b98 into main Oct 30, 2025
14 checks passed

bjorntore deleted the feat/pdf-service-task branch October 30, 2025 10:34

Feat/service task #745

Feat/service task #745

Uh oh!

Conversation

bjorntore commented Sep 4, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Verification

Documentation

Summary by CodeRabbit

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 4, 2024

Quality Gate passed

Uh oh!

Uh oh!

martinothamar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 23, 2024

Quality Gate passed

Uh oh!

sonarqubecloud bot commented Dec 6, 2024

Quality Gate passed

Uh oh!

sonarqubecloud bot commented Jan 20, 2025

Quality Gate passed

Uh oh!

sonarqubecloud bot commented Mar 10, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bjorntore commented Jul 4, 2025

Uh oh!

github-actions bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR release:

Uh oh!

sonarqubecloud bot commented Jul 4, 2025

Quality Gate passed

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bjorntore commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR release:

bjorntore commented Sep 4, 2024 •

edited by coderabbitai bot

Loading

github-actions bot commented Jul 4, 2025 •

edited

Loading

github-actions bot commented Oct 14, 2025 •

edited

Loading

github-actions bot commented Oct 30, 2025 •

edited

Loading

github-actions bot commented Oct 30, 2025 •

edited

Loading